#46266 [SC-Insight] Cannot use a pool token suffix of MAX_SUFFIX_LEN
Submitted on May 27th 2025 at 14:47:51 UTC by @Oxgritty for Audit Comp | Flare | FAssets
- Report ID: #46266
- Report Type: Smart Contract
- Report severity: Insight
- Target: https://github.com/flare-foundation/fassets/blob/main/contracts/assetManager/library/AgentsCreateDestroy.sol
- Impacts:
Description
Brief/Intro
- When agent owner wants to create a vault, along with other parameters he also has to provide
poolTokenSuffix, now the intended behaviour is that, its maximum length can be ofMAX_SUFFIX_LENbut due to a logical error, agent owner can only provide apoolTokenSuffixof max lengthMAX_SUFFIX_LEN - 1.
Vulnerability Details
- For creating an agent
createAgentVaultfunction is called along with certain parameters of typeAgentSettings.Data calldata _settings, inside_settingsthere is one parameter called_settings.poolTokenSuffix, now its max length can be ofMAX_SUFFIX_LEN, but due the use of<instead of<=, its maximum allowed length isMAX_SUFFIX_LEN - 1.
Impact Details
- The maximum length allowed for
poolTokenSuffixwill beMAX_SUFFIX_LEN - 1, which is 1 less than the intended length.
References
Proof of Concept
Proof of Concept
- Agent owner calls
createAgentVaultwith_settingsand length of_settings.poolTokenSuffixis equal toMAX_SUFFIX_LEN. - The code will revert in
_reserveAndValidatePoolTokenSuffixdue to following check:
require(len < MAX_SUFFIX_LEN, "suffix too long");