# 51493 sc insight misleading view function documentation

Submitted on Aug 3rd 2025 at 11:20:30 UTC by @heavyw8t for [Attackathon | Plume Network](https://immunefi.com/audit-competition/plume-network-attackathon)

* Report ID: #51493
* Report Type: Smart Contract
* Report severity: Insight
* Target: <https://github.com/immunefi-team/attackathon-plume-network/blob/main/plume/src/facets/RewardsFacet.sol>
* Impacts: (none specified)

{% hint style="info" %}
Brief/Intro

The `_earned` function in `RewardsFacet.sol` is documented as an "Internal View Function" but actually modifies state by calling `calculateRewardsWithCheckpoints()`, which updates storage variables.
{% endhint %}

## Vulnerability Details

See POC

## Impact Details

Insight: The documentation is incorrect and misleading.

## Proof of Concept

<details>

<summary>Proof of Concept — details</summary>

The function comment states "Internal View Function (earned)," but the implementation calls `PlumeRewardLogic.calculateRewardsWithCheckpoints()`, which in turn calls `updateRewardPerTokenForValidator()`. This function modifies several storage variables:

* `$.validatorLastUpdateTimes[validatorId][token] = block.timestamp`
* `$.validatorRewardPerTokenCumulative[validatorId][token] += rewardPerTokenIncrease`
* `$.validatorAccruedCommission[validatorId][token] += commissionDeltaForValidator`

</details>


---

# Agent Instructions: Querying This Documentation

If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question.

Perform an HTTP GET request on the current page URL with the `ask` query parameter:

```
GET https://reports.immunefi.com/plume-or-attackathon/51493-sc-insight-misleading-view-function-documentation.md?ask=<question>
```

The question should be specific, self-contained, and written in natural language.
The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.
