> For the complete documentation index, see [llms.txt](https://reports.immunefi.com/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://reports.immunefi.com/plume-or-attackathon/51493-sc-insight-misleading-view-function-documentation.md).

# 51493 sc insight misleading view function documentation

Submitted on Aug 3rd 2025 at 11:20:30 UTC by @heavyw8t for [Attackathon | Plume Network](https://immunefi.com/audit-competition/plume-network-attackathon)

* Report ID: #51493
* Report Type: Smart Contract
* Report severity: Insight
* Target: <https://github.com/immunefi-team/attackathon-plume-network/blob/main/plume/src/facets/RewardsFacet.sol>
* Impacts: (none specified)

{% hint style="info" %}
Brief/Intro

The `_earned` function in `RewardsFacet.sol` is documented as an "Internal View Function" but actually modifies state by calling `calculateRewardsWithCheckpoints()`, which updates storage variables.
{% endhint %}

## Vulnerability Details

See POC

## Impact Details

Insight: The documentation is incorrect and misleading.

## Proof of Concept

<details>

<summary>Proof of Concept — details</summary>

The function comment states "Internal View Function (earned)," but the implementation calls `PlumeRewardLogic.calculateRewardsWithCheckpoints()`, which in turn calls `updateRewardPerTokenForValidator()`. This function modifies several storage variables:

* `$.validatorLastUpdateTimes[validatorId][token] = block.timestamp`
* `$.validatorRewardPerTokenCumulative[validatorId][token] += rewardPerTokenIncrease`
* `$.validatorAccruedCommission[validatorId][token] += commissionDeltaForValidator`

</details>


---

# Agent Instructions
This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com.

## Querying This Documentation
If you need additional information that is not directly available in this page, you can query the documentation by asking a question.

Perform an HTTP GET request on the following URL with the `ask` and `goal` query parameters:

```
GET https://reports.immunefi.com/plume-or-attackathon/51493-sc-insight-misleading-view-function-documentation.md?ask=<question>&goal=<user_goal>
```

`ask` is the immediate question: it should be specific, self-contained, and written in natural language.
`goal` is what the user is ultimately trying to achieve, the reason they need the answer. Sharing it helps GitBook give you a better, more relevant answer. A goal is most helpful when it describes the outcome the user wants rather than restating the question. For example, with `ask=how do I create an API token`, a goal like `automate deployments from our CI pipeline` lets GitBook tailor the answer to that use case.

The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.
