> For the complete documentation index, see [llms.txt](https://reports.immunefi.com/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://reports.immunefi.com/alchemix-v3/58322-sc-low-incorrect-emit-due-to-wrong-ordering-of-wethbalancebefore-calculation.md). # 58322 sc low incorrect emit due to wrong ordering of wethbalancebefore calculation **Submitted on Nov 1st 2025 at 09:08:33 UTC by @SOPROBRO for** [**Audit Comp | Alchemix V3**](https://immunefi.com/audit-competition/alchemix-v3-audit-competition) * **Report ID:** #58322 * **Report Type:** Smart Contract * **Report severity:** Low * **Target:** * **Impacts:** * Contract fails to deliver promised returns, but doesn't lose value ## Description ## Brief/Intro In `MorphoYearnOGWETH::_deallocate`, the function incorrectly calculates `wethBalanceBefore` after performing the `vault.withdraw` call. This causes `wethRedeemed` to always evaluate to `0`, resulting in an incorrect emission of a `StrategyDeallocationLoss` event even when there is no actual loss. ## Vulnerability Details ```solidity vault.withdraw(amount, address(this), address(this)); // @audit `wethBalanceBefore` is calculated after withdrawal uint256 wethBalanceBefore = TokenUtils.safeBalanceOf(address(weth), address(this)); uint256 wethBalanceAfter = TokenUtils.safeBalanceOf(address(weth), address(this)); uint256 wethRedeemed = wethBalanceAfter - wethBalanceBefore; if (wethRedeemed < amount) { emit StrategyDeallocationLoss("Strategy deallocation loss.", amount, wethRedeemed); } ``` The issue is that `wethBalanceBefore` should represent the contract’s WETH balance **before** the withdrawal is executed.\ However, since it is calculated **after** the `vault.withdraw` call, both `wethBalanceBefore` and `wethBalanceAfter` are the same, leading to: ```solidity wethRedeemed = wethBalanceAfter - wethBalanceBefore = 0 ``` This triggers a false `StrategyDeallocationLoss` event regardless of whether the strategy incurred a real loss. ## Impact Details The `StrategyDeallocationLoss` event will always be emitted, even when there are no losses, which may result in false alerts ## References (Code Location) ## Proof of Concept ## Proof Of Concept Add the following test to `MorphoYearnOGWETHStrategy.t.sol` and run in the console `forge test --mt test_strat_always_emits_strat_loss -vv`, and see that the following event will be emitted `emit StrategyDeallocationLoss("Strategy deallocation loss.", 5e18, 0);` ```solidity event StrategyDeallocationLoss(string message, uint256 amountRequested, uint256 actualAmountSent); function test_strat_always_emits_strat_loss() public { uint256 amountToAllocate = 10e18; uint256 amountToDeallocate = amountToAllocate / 2; vm.startPrank(vault); deal(testConfig.vaultAsset, strategy, amountToAllocate); bytes memory prevAllocationAmount = abi.encode(0); IMYTStrategy(strategy).allocate(prevAllocationAmount, amountToAllocate, "", address(vault)); bytes memory prevAllocationAmount2 = abi.encode(amountToAllocate); vm.expectEmit(); emit StrategyDeallocationLoss("Strategy deallocation loss.", 5e18, 0); IMYTStrategy(strategy).deallocate(prevAllocationAmount2, amountToDeallocate, "", address(vault)); } ``` --- # Agent Instructions This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com. ## Querying This Documentation If you need additional information that is not directly available in this page, you can query the documentation by asking a question. Perform an HTTP GET request on the following URL with the `ask` and `goal` query parameters: ``` GET https://reports.immunefi.com/alchemix-v3/58322-sc-low-incorrect-emit-due-to-wrong-ordering-of-wethbalancebefore-calculation.md?ask=&goal= ``` `ask` is the immediate question: it should be specific, self-contained, and written in natural language. `goal` is what the user is ultimately trying to achieve, the reason they need the answer. Sharing it helps GitBook give you a better, more relevant answer. A goal is most helpful when it describes the outcome the user wants rather than restating the question. For example, with `ask=how do I create an API token`, a goal like `automate deployments from our CI pipeline` lets GitBook tailor the answer to that use case. The response will contain a direct answer to the question and relevant excerpts and sources from the documentation. Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.