30992 - [SC - Insight] Inconsistent State Missing Event Emission in Fl...
Last updated
Was this helpful?
Last updated
Was this helpful?
Submitted on May 10th 2024 at 08:29:50 UTC by @Wizard for
Report ID: #30992
Report type: Smart Contract
Report severity: Insight
Target: https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/FluxToken.sol
Impacts:
contracts or users may not be aware that an NFT has been claimed, leading to inconsistent state
The FluxToken.sol::nftClaim function does not emit an event when an NFT is claimed, which can lead to inconsistent state.
The nftClaim function marks an NFT as claimed by setting claimed[_nft][_tokenId] = true, but it does not emit an event to notify external contracts that the NFT has been claimed. This is an important step in tracking claimed NFTs.
While there are no direct financial losses associated with the missing event., not emitting an event would make logging and tracing claimed NFTs much harder for external contracts relying on the function's input.
https://github.com/alchemix-finance/alchemix-v2-dao/blob/main/src/FluxToken.sol?utm_source=immunefi#L134