# 26530 - \[SC - Insight] Inefficiency in upgradeToAndCall Submitted on Dec 4th 2023 at 14:53:54 UTC by @whunter for [Boost | DeGate](https://immunefi.com/bounty/boosteddegatebugbounty/) Report ID: #26530 Report type: Smart Contract Report severity: Insight Target: Impacts: * Contract fails to deliver promised returns, but doesn't lose value ## Description ## Bug Description ``` function upgradeTo(address implementation) public onlyProxyOwner { _upgradeTo(implementation); } function upgradeToAndCall(address implementation, bytes memory data) payable public onlyProxyOwner { upgradeTo(implementation); (bool success, ) = address(this).call{value: msg.value}(data); require(success); } ``` In `upgradeToAndCall`, after calling `upgradeTo`, it calls itself. `msg.sender` will be the proxy address there. It would be better to call implementation directly because the proxy itself has only privileged functions and it's unlikely that proxyOwner is proxy itself. ## Impact Inefficiency in upgradeToAndCall. Potential reputation damage to the protocol due to unoptimized code. ## Risk Breakdown Difficulty to Exploit: Easy Weakness: CVSS2 Score: ## Recommendation Call (delegate) the implementation directly. ## References --- # Agent Instructions: Querying This Documentation If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question. Perform an HTTP GET request on the current page URL with the `ask` query parameter: ``` GET https://reports.immunefi.com/degate/26530-sc-insight-inefficiency-in-upgradetoandcall.md?ask= ``` The question should be specific, self-contained, and written in natural language. The response will contain a direct answer to the question and relevant excerpts and sources from the documentation. Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.