# 26527 - \[SC - Insight] Possible emission of wrong data in cancelTransa... Submitted on Dec 4th 2023 at 14:22:36 UTC by @Obin for [Boost | DeGate](https://immunefi.com/bounty/boosteddegatebugbounty/) Report ID: #26527 Report type: Smart Contract Report severity: Insight Target: Impacts: * Contract can wrongly emit cancellation of not-previously-queued Tx ## Description ## Bug Description The `cancelTransaction()` only sets the hash of the inputs to false. this implementation is sub-optimal and buggy as contract doesn't check if inputed data is correct. ## Impact In situation of input error, this will lead to: 1. Not actually deleting Tx as intended 2. Wrongly publishing / emitting a false data to have been cancelled. ## Recommendation ```diff function cancelTransaction(address target, uint value, string memory signature, bytes memory data, uint eta) public { require(msg.sender == admin, "Timelock::cancelTransaction: Call must come from admin."); bytes32 txHash = keccak256(abi.encode(target, value, signature, data, eta)); + require(queuedTransactions[txHash], "Timelock::cancelTransaction:Incorrect input or not queued"); queuedTransactions[txHash] = false; emit CancelTransaction(txHash, target, value, signature, data, eta); } ``` ## Reference --- # Agent Instructions: Querying This Documentation If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question. Perform an HTTP GET request on the current page URL with the `ask` query parameter: ``` GET https://reports.immunefi.com/degate/26527-sc-insight-possible-emission-of-wrong-data-in-canceltransa....md?ask= ``` The question should be specific, self-contained, and written in natural language. The response will contain a direct answer to the question and relevant excerpts and sources from the documentation. Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.